Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "completed" guide animation #149530

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Implement "completed" guide animation #149530

merged 2 commits into from
Jan 30, 2023
+26 −2

Conversation

claracruz
Copy link
Contributor

@claracruz claracruz commented Jan 25, 2023 •
edited
Loading

Fixes #147387

Screenshots

Screenshot 2023-01-27 at 14 49 09

Screenshot 2023-01-27 at 14 49 52

@claracruz claracruz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Journey/Onboarding Platform Journey Onboarding team v8.7.0 labels Jan 25, 2023
@claracruz claracruz requested a review from a team as a code owner January 25, 2023 16:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@yuliacech yuliacech requested a review from cindychangy January 26, 2023 11:41
@yuliacech
Copy link
Contributor

@cindychangy Do we have a dark theme support for the "completed guide" GIF?

yuliacech
yuliacech suggested changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this, @claracruz!
I tested locally and saw that the gif is displayed from the very beginning of the guide. We should only display the animation when the guide is in the status ready_to_complete and complete. Also, is there is specific reason to use EuiEmptyPrompt for the gif? Can we maybe use a simple EuiImage instead?

@cindychangy
Copy link
Contributor

@cindychangy Do we have a dark theme support for the "completed guide" GIF?

@yuliacech: we actually did not get one from the Branding team - I just contact them for a dark mode version. I will let you know when I receive it - should we add it in an additional task so as not to block this one?

@cindychangy
Copy link
Contributor

@claracruz @yuliacech: I got the dark mode version for this animation, it is attached below:
guide-complete-animation-dark

@yuliacech
Copy link
Contributor

Thanks a lot, @cindychangy!
@claracruz Could you please add the dark theme gif to the code? here is the link to the file (link).

@claracruz claracruz force-pushed the implement-completed-guide-animation branch from 4e8a641 to 1de94c1 Compare January 27, 2023 14:32
@claracruz claracruz force-pushed the implement-completed-guide-animation branch from 1de94c1 to aeeb5c9 Compare January 30, 2023 10:54
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
guidedOnboarding 21 23 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 23.1KB 23.7KB +585.0B
Unknown metric groups

miscellaneous assets size

id before after diff
guidedOnboarding 1.9MB 3.3MB ⚠️ +1.4MB

History

  • 💚 Build #103384 succeeded 1de94c134d1954033b03581c3a2e48a697c67465
  • 💚 Build #102669 succeeded 4e8a64133d0ea09d3b421906f3d874dd796cfb78

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this, @claracruz! Looks great 👍

@claracruz claracruz merged commit 1a05388 into elastic:main Jan 30, 2023
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@claracruz @kqualters-elastic
Implement "completed" guide animation (elastic#149530)
ce73652 
Fixes elastic#147387

### Screenshots

<img width="522" alt="Screenshot 2023-01-27 at 14 49 09"
src="https://user-images.githubusercontent.com/91763/215115481-beab7f69-60c6-48f5-8ab0-d8dcb67fabb7.png">

<img width="559" alt="Screenshot 2023-01-27 at 14 49 52"
src="https://user-images.githubusercontent.com/91763/215115506-5bf328a0-7b47-44d5-b9db-62f5a30dfed7.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bollinic bollinic bollinic approved these changes

@cindychangy cindychangy cindychangy approved these changes

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Guided onboarding] Implement "completed" guide animation
6 participants
@claracruz @elasticmachine @yuliacech @cindychangy @kibana-ci @bollinic